New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] `check` command do not list all ink dependencies correctly #203

Open

ipapandinas opened this issue Jan 16, 2024 · 0 comments

Labels

bug good first issue

Contributor

ipapandinas commented Jan 16, 2024

Description

swanky-cli/src/commands/check/index.ts

Line 82 in 9a9d290

.filter((dependency) => dependency[0].includes("ink_"))

Here we should filter both possible dependency types: "ink" & "ink_" (e.g. "ink_e2e").
We can use this filter approach instead:

.filter(([depName]) => /^ink($|_)/.test(depName))

The text was updated successfully, but these errors were encountered:

ipapandinas added bug good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment