fix: return the updated credential from process_credential() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Voiturier <[email protected]>
bvoiturier
requested review from
hamada147,
FabioPinheiro and
goncalo-frade-iohk
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
hamada147
approved these changes
Dec 14, 2023
FabioPinheiro
approved these changes
Dec 18, 2023
goncalo-frade-iohk
approved these changes
Dec 18, 2023
goncalo-frade-iohk
pushed a commit
that referenced
this pull request
Dec 18, 2023
fix: return the updated credential from process_credential() Signed-off-by: Benjamin Voiturier <[email protected]> Signed-off-by: Ahmed Moussa <[email protected]> Co-authored-by: Ahmed Moussa <[email protected]> Signed-off-by: goncalo-frade-iohk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
process_credentialgets its parameters with pass-by-reference. It can change their values, so we need to handle this case for the other programming languages (Kotlin, Swift, Scala).