Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: showing relevance proposal #3546

Open
ksachs opened this issue Jul 16, 2018 · 1 comment
Open

GUI: showing relevance proposal #3546

ksachs opened this issue Jul 16, 2018 · 1 comment

Comments

@ksachs
Copy link
Contributor

ksachs commented Jul 16, 2018

As sources for proposals we currently have

  • harvested category with auto-accept / auto-CORE
  • CORE guesser with score and a proposal
  • CORE keywords with a proposal (display in color)
  • CORE references

these informations are used in different functions defined in

inspirehep/modules/workflows/workflows/article.py 
inspirehep/modules/workflows/tasks/actions.py
inspirehep/modules/workflows/tasks/matching.py  (auto_approve)
inspirehep-search-js/blob/master/src/inspirehep-holdingpen-js/templates/inspirehep-holdingpen-js/results/results.html (color for keywords)
inspirehep-search-js/blob/master/src/inspirehep-holdingpen-js/templates/inspirehep-holdingpen-js/details/details_decision_hep.html  (color for keywords)

Still to come

  • color display for CORE references
  • more sources for information
  • combine the proposals

Needed soon

color display for CORE references.
This can be done in js, but it gets complicated.
I would prefer a python function, store the proposal in extra-data, which is used in js to select the color/class.

Re-organize code?

My naive approach would have been one function called by the workflow (similar to is_record_relevant) for all relevance/reject/accept decisions. Which calls functions to

  • calculate proposal from CORE keywords and store result in extra_data
  • calculate proposal from CORE references and store result in extra_data
  • ....
  • calculate overall proposal by combining information

Which then leads to actions (auto-accept, auto-reject) and can be used for color-display and to highlight the button we are encouraged to click.

@ksachs ksachs added this to the Holding Pen Usability milestone Jul 16, 2018
@ksachs
Copy link
Contributor Author

ksachs commented Oct 18, 2018

This is how it could look like:

Display result of steps that are used to make a proposal for accept/core.
If there is no information (e.g. no PACS, this line doesn't need to be displayed).
Display information in color according to proposal (CORE, Accept, Reject, No-Proposal).

If the single proposals are combined to an overall proposal, highlight the corresponding button.
For auto-accept records lowlight (not fully disable) the reject button.
I.e. there are 3 levels: encourage - normal - discourage.
Our proposal would be normal = transparent ; highlight = full color; lowlight = gray.
If there is no overall proposal the buttons would have the same transparency.

It should be easy to change and add criteria for single proposals as well as for the overall proposal.
It will be too complex for config parameters, but is should not be buried and scattered all over the code.

List view

image

Auto-accepted records

i.e. fully harvested journals / arXiv categories
The overall proposal would be at least Accept

image

Detailed view

it can have more information; if it is the same info, the wording and layout should be the same as on brief (if possible re-use the code)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant