-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requestTime error in production app #101
Comments
We're getting the same error, running the latest version:
|
The same in production for multiple devices
|
Up! |
The same with issue: |
Some exceptions are deemed fatal by RxJava, causing it to crash instead of calling your error handler. One potential fix is to wrap exceptions to prevent crashes. If your application truly needs a synced time to function properly, you can choose how to handle those cases in the Here's an example in Kotlin: Single
.fromCallable {
Log.d(javaClass.simpleName, "Running sync().")
}
.flatMap {
try {
TrueTimeRx.build()
.withSharedPreferencesCache(applicationContext)
.initializeNtp("time.google.com")
// To test with a fatal exception here: throw ThreadDeath()
} catch (t: Throwable) {
// Wrap exception in case it's fatal
Single.error<LongArray>(t)
}
}
.subscribeOn(Schedulers.io())
.subscribe(
{
Log.e(javaClass.simpleName, "" + it)
},
{
Log.e(javaClass.simpleName, it.toString())
}
) |
we're seeing the same issue; didn't appear in the phones we developed with, but, appears once we went to 1% rollout to real customers. Looked really bad as our customer (B2B2C) hosts the app and sees the crashlytics, bit us hard. :( obviously instacart doesn't care about this library anymore, needs a fork |
The try/catch approach didn't seem to help us that much. Setting a global RxJava error handler, however, is working for us! We haven't seen a crash related to this issue since. RxJavaPlugins.setErrorHandler {
// Log, eat error, etc.
// Note: this likely is not executed on the main thread
} Reference: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling We are still receiving a few of these errors, though:
|
Does anyone know the cause of this error re: "Operation not permitted"? We'd prefer to fix the actual issue instead of just swallowing the error. |
This has to be solved, not muted. Any suggestions? |
I've posted my finding in here: #119 (comment) |
Hi all, this is the log I got from my production app
I got this error many time starting from October 1st
Please let me know how to fix it. This is the version I'm using
implementation 'com.github.instacart.truetime-android:library-extension-rx:09087b6a6e'
The text was updated successfully, but these errors were encountered: