Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra node process is terminated when there is an issue with Cassandra-exporter agent #68

Open
podile opened this issue Feb 21, 2020 · 6 comments

Comments

@podile
Copy link

podile commented Feb 21, 2020

Cassandra node process is terminated when cassandra-exporter agent fails to initialize. The impact may be less for smaller Cassandra environments, but the impact is more on bigger Cassandra environments. Agent should not terminate the node process if there any error during initialization. Introduce a new flag based initialization logic to drop agent initialization in case of any error allow the node process to continue.

@podile
Copy link
Author

podile commented Feb 21, 2020

I will work on this enhancement.

@zegelin
Copy link

zegelin commented Feb 21, 2020

I disagree. The agent is an extension to Cassandra. Any error in the Cassandra config prevents Cassandra from starting. Likewise, any config error with the exporter agent should follow the same pattern.

@podile
Copy link
Author

podile commented Feb 22, 2020

I completely agree that patterns wise the process should get terminated in case of any issue with config, and that should be the default behavior. Adding a flag (--dont_exit_on_error) to continue the node process if agent could't initialize will give peace of mind to the users who maintain huge clusters.

@zegelin
Copy link

zegelin commented Feb 24, 2020

What kind of errors are we talking about here? Configuration problems should abort IMO.

@podile
Copy link
Author

podile commented Feb 26, 2020

Configuration problems should abort cassandra-exporter agent initialization, should the node process be aborted if Casandra-exporter fails to initialize?

@zegelin
Copy link

zegelin commented Feb 26, 2020

Hi @podile. I now have a better understanding of the need for this feature and happy for abort-on-config-problems to be put behind a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants