-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cassandra node process is terminated when there is an issue with Cassandra-exporter agent #68
Comments
I will work on this enhancement. |
I disagree. The agent is an extension to Cassandra. Any error in the Cassandra config prevents Cassandra from starting. Likewise, any config error with the exporter agent should follow the same pattern. |
I completely agree that patterns wise the process should get terminated in case of any issue with config, and that should be the default behavior. Adding a flag (--dont_exit_on_error) to continue the node process if agent could't initialize will give peace of mind to the users who maintain huge clusters. |
What kind of errors are we talking about here? Configuration problems should abort IMO. |
Configuration problems should abort cassandra-exporter agent initialization, should the node process be aborted if Casandra-exporter fails to initialize? |
Hi @podile. I now have a better understanding of the need for this feature and happy for abort-on-config-problems to be put behind a flag. |
Cassandra node process is terminated when cassandra-exporter agent fails to initialize. The impact may be less for smaller Cassandra environments, but the impact is more on bigger Cassandra environments. Agent should not terminate the node process if there any error during initialization. Introduce a new flag based initialization logic to drop agent initialization in case of any error allow the node process to continue.
The text was updated successfully, but these errors were encountered: