Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt #99

Open
1 of 7 tasks
macoca opened this issue Apr 25, 2018 · 0 comments
Open
1 of 7 tasks

Technical debt #99

macoca opened this issue Apr 25, 2018 · 0 comments
Milestone

Comments

@macoca
Copy link
Contributor

macoca commented Apr 25, 2018

  • Autosave middleware for campaigns. Actions shouldn't have side effects.
  • Views shouldn't have knowledge of the internal store structure
  • Reducer testing
  • Flow/Session/Broker responsibilities
  • Use Verboice url from config on:
    base_url = "https://verboice-stg.instedd.org"
  • Remove Camel Case encoder from global config:
# Encode JSON properties as camelCase before sending
config :phoenix, :format_encoders,
  json: ProperCase.JSONEncoder.CamelCase

Remove the config and encode from client side

  • Forwarding email should be pretty
@macoca macoca added this to the 0.3 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant