Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical debt/pendings 0.3 #37

Open
18 of 27 tasks
bcardiff opened this issue Dec 7, 2017 · 1 comment
Open
18 of 27 tasks

Technical debt/pendings 0.3 #37

bcardiff opened this issue Dec 7, 2017 · 1 comment
Labels

Comments

@bcardiff
Copy link
Contributor

bcardiff commented Dec 7, 2017

Technical debt

  • console.log in debounced actions
  • reduce boilerplate in redux actions (splitting constants, using objects instead of switch)
  • Use lodash for scope and some map operations coded before it was included
  • Probably use a strategy per skill
  • Translation api is not defined in schema.json (rather than directly in type)
  • Add publish_success, unpublish_success actions and keep published flag up to date in reducers instead of actions.
  • Proper error handling when publishing a bot
  • Extract common rspec idioms into matchers and whatnot
  • More validations to XLS form parsing
  • Index survey translations by variable name instead of option/question index
  • Review and unify error handling in controllers
  • Race condition in bot deletion. Delete, Navigate, Fetch, Proper delete.

UX pending

  • Change rename of bot to use dialog instead of inplace edition (or at least focus on the editable title)
  • Translations of default language are readonly, but there is no clear ui indication of that.
  • When no language detector is available the translation missing should be visible at all?
  • When a bot is not published, should analytics be visible at all?
  • What should be the default page for a bot? (it might depend on the state to simulate an onboarding)
  • Use a proper filter select for the language in the language detector
  • Track changes to the bot and show that the published bot is out-of-date

UI pending

  • Navigation tabs responsive behaviour
  • Make all anchors appear with app main color (e.g. Behaviour > Survey skill > "these tools" link
  • Remove bottom border of '.mainToolbar nav' for mainTabs nav
  • Make buttons in Behaviour sticky to the bottom of div
  • Check that all hover/focus buttons have 5/10% transparency in rgb color (make sure focus class doesn't get replaced w/hover)
  • Check all styles in Mozilla browser
    • Change links color to secondary-color
    • [ ] Make button-area mobile friendly
  • Add/Cancel button when adding skills in Sidebar should have the opposite style
@instedd instedd deleted a comment from pmallol Dec 14, 2017
@ggiraldez
Copy link
Member

Moved other checklist comments into the main one for Github's UI to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants