Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade E2E CI job to align with Medium-size CLI job #276

Closed
nathan-weinberg opened this issue Oct 16, 2024 · 0 comments · Fixed by #277
Closed

Upgrade E2E CI job to align with Medium-size CLI job #276

nathan-weinberg opened this issue Oct 16, 2024 · 0 comments · Fixed by #277
Assignees
@nathan-weinberg
Labels
CI/CD Affects CI/CD configuration enhancement New feature or request

Comments

@nathan-weinberg
Copy link
Member

The current E2E job in this repo is quite old and not super useful - it tests the simple training pipeline which doesn't even use the training library

We'd be better off replacing it with a job that aligns with the Medium-size job in the CLI repo, to test compatibility changes with the full training CLI pipeline which does interface with this library
@nathan-weinberg nathan-weinberg added enhancement New feature or request CI/CD Affects CI/CD configuration labels Oct 16, 2024
@nathan-weinberg nathan-weinberg self-assigned this Oct 16, 2024
@nathan-weinberg nathan-weinberg linked a pull request Oct 16, 2024 that will close this issue
e2e: replace old small job with new medium job #277
Merged
@mergify mergify bot closed this as completed in #277 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathan-weinberg nathan-weinberg

Labels
CI/CD Affects CI/CD configuration enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e: replace old small job with new medium job nathan-weinberg/training
1 participant
@nathan-weinberg