Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migtd: abstract vmcall operations into VmcallService #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

migtd: abstract vmcall operations into VmcallService #198

wants to merge 2 commits into from

Conversation

gaojiaqi7
Copy link
Contributor

There are several duplicate code blocks for setting up buffers, executing and parsing return values for TDVMCALL<Service>.

Here the vmcall operations are abstracted into a struct VmcallService to eliminite the duplicate code.

@gaojiaqi7
migtd: expose the data slice of VmcallServiceResponse
d192dff 
Consumer of this structure may have the requirement to read the data
in slice rather than deserializing bytes into struct directly with
`read_data()` method.

Signed-off-by: Jiaqi Gao <[email protected]>
@gaojiaqi7
migtd: abstract vmcall operations into VmcallService
0a9b33d 
There are several duplicate code blocks for setting up buffers,
executing and parsing return values for `TDVMCALL<Service>`.

Here the vmcall operations are abstracted into a struct `VmcallService`
to eliminite the duplicate code.

Signed-off-by: Jiaqi Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaojiaqi7