Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Latest commit

 

History

History
15 lines (8 loc) · 2.24 KB

BACKPORTS.md

File metadata and controls

15 lines (8 loc) · 2.24 KB

As documented in RELEASES.md, the individual(s) on backports rotation are responsible for doing backports for security releases, and other qualifying backports.

Backports rotation folks should make sure they have triage rights (ask one of the admins to give you access if you do not otherwise have it), and regularly triage backports-review issues, either removing the backports-review tag and adding backports-approved, or pushing back in comments for why the issue does not qualify based on RELEASES.md

For approved PRs, the person on rotation should backport them to supported binaries, based on the support window also in RELEASES.md

The individual branches can be checked out per normal github workflow, and reviews for backport PRs sent to the original PR author and/or reviewers for approval.

See #17814 as an example backport, referencing the original PR

See the fix lead checklist for git commands to backport an example patch. Backports rotation assignee may or may not be the fix lead for a given security release.

When the maintainer team kicks off a security release, the fix lead should add backports rotation to the release-specific slack channel for general coordination, and one of the admins should grant access to envoy-setec repo. As issues tagged cve-next are merged into main, the backports folks are responsible for backporting to the supported releases. In this case, fix lead is responsible for kicking off the actual release branches.

For security backports best-practices include creating a patch per backport to make sure they individually pass CI, and then creating one rollup patch which is those patches combined, to make sure they merge cleanly.