This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
Signed-off-by: giantcroc <[email protected]>
@soulxu Could you please review this PR? |
soulxu
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
gyohuangxin
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giantcroc Thanks! LGTM
gyohuangxin
pushed a commit
that referenced
this pull request
Mar 15, 2024
* zstd compressor refactor * add qatzstd to contrib * fix decompressor * support qatzstd * add qatzstd test * fix api * use logger id compression * add doc and format * trim whitespace * fix memcpy * remove dictionary due to not support for qatzstd * fix BUILD * fix proto format * fix docs * fix clang build * fix unused parameter * remove unused vars * use operator instead if * use protected * fix comments * add more api comments * fix proto format Signed-off-by: giantcroc <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]