Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va: remove older 0.32 and 0.33 support #812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XinfengZhang
Copy link
Contributor

libva version 2.x should be compatible with 2.x series , not 1.x series and 0.x series
copy #811, but reserve va_compat.h , because maybe some existing usage refer this file

libva version 2.x should be compatible with 2.x series , not 1.x series
and 0.x series
reserve va_compat.h , because maybe some existing usage refer this file

Signed-off-by: Carl Zhang <[email protected]>
Copy link
Contributor

@xhaihao xhaihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evelikov
Copy link
Contributor

evelikov commented Jun 4, 2024

AFAICT this will cause an ABI break, since any program linked against libva.so.2 has the VA_API_0.33.0 tagged vaCreateSurfaces symbol.

This compat shim (alongside other deprecated bits) should have been removed with the libva.so.1 -> libva.so.2 change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants