Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: AV1 decode support in media-driver without any kernels built #1832

Open
frantisekz opened this issue Jul 12, 2024 · 5 comments
Open
Assignees
Labels
AV1 AV1 Decode video decode related Feature Request Request a feature or enhancement Reserved Information to describe some implementation detail or restriction

Comments

@frantisekz
Copy link

What Feature?

AV1 decode is currently exposed in vainfo on supported HW, but the decoding itself fails if the media-driver is built without any kernels (neither free nor non-free), supposedly because the required filmgrain kernel for AV1 decode.

Would it be possible to implement some fallback path so the driver makes the decoding at least partially on GPU on supported hardware even without any kernels built in?

I can add ffmpeg verbose log once I get to the HW that supports AV1.

Thanks!

What's the usage scenario would be benifited?

Playback, Web browser

What impacted?

No response

Do you want to contribute a patch to develop this feature?

None

@frantisekz frantisekz added the Feature Request Request a feature or enhancement label Jul 12, 2024
@Sherry-Lin
Copy link
Contributor

Thanks for your feedback. Media-driver default build supports full features. Could you provide more background why not choose default build?

@Sherry-Lin Sherry-Lin added Decode video decode related AV1 AV1 labels Jul 15, 2024
@frantisekz
Copy link
Author

Hey @Sherry-Lin , thanks for the reply!

This is due to media-driver package in Fedora, where I, as a package maintainer, can't use prebuilt binaries due to patents and distribution policy, and rebuilding the kernels is broken as discussed in #1775 and #1356 .

@intel-mediadev
Copy link
Contributor

Auto Created VSMGWL-74924 for further analysis.

@Jexu
Copy link
Contributor

Jexu commented Jul 17, 2024

AV1 filmgrain kernel only exists on several platforms and it already moves to fix function from mtl without kernel anymore.
I think it maybe hard to get priorized so far unless having any customer special usage.

@Jexu Jexu self-assigned this Jul 17, 2024
@frantisekz
Copy link
Author

frantisekz commented Jul 17, 2024

Okay, thanks @Jexu , that's good to know, I am not able to test this as the latest HW I have available fails to decode the AV1 without kernels (Xe iGPU, 13th gen CPU).

@Jexu Jexu added the Reserved Information to describe some implementation detail or restriction label Jul 18, 2024
Jexu added a commit to Jexu/media-driver that referenced this issue Sep 19, 2024
Fixes: intel#1852, intel#1832
Av1 decode needs filmgrain kernel support, and free kernel build will
not support av1 decode.

Signed-off-by: Xu, Zhengguo <[email protected]>
Jexu added a commit to Jexu/media-driver that referenced this issue Sep 19, 2024
Fixes: intel#1852, intel#1832
Av1 decode needs filmgrain kernel support, and free kernel build will
not support av1 decode.

Signed-off-by: Xu, Zhengguo <[email protected]>
intel-mediadev pushed a commit that referenced this issue Oct 11, 2024
Fixes: #1852, #1832
Av1 decode needs filmgrain kernel support, and free kernel build will
not support av1 decode.

Signed-off-by: Xu, Zhengguo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AV1 AV1 Decode video decode related Feature Request Request a feature or enhancement Reserved Information to describe some implementation detail or restriction
Projects
None yet
Development

No branches or pull requests

5 participants