-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency manager #795
Comments
a good idea. Will try it when we will have more dependencies to justify it and improve ROI |
I can try to integrate CPM, if you want. |
@artiomn rdementi is supposed to be on vacation this week, don't make him work so hard ;-) |
Ok, I'm waiting. :-) |
Thanks for volunteering! I discussed it with @twillhal . Adding cmake/CPM.cmake would potentially require an internal review and approval. We will do it but unfortunately I can't give a timeline. |
I can do this, if you approve this change. |
adding CPM.cmake has been approved. It is now in the master branch: https://github.com/intel/pcm/blob/master/cmake/CPM.cmake |
Currently only SIMDJSON is used as a submodule. But in the future there may be other dependencies (for example, a third-party HTTP server or exclude getopt from the codebase).
Submodules are very inconvenient, not very effective, and tie the project to a version control system, which should not be the case.
Probably better solution will be use dependency manager. CPM is lightweight and written in pure CMake.
The text was updated successfully, but these errors were encountered: