Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x) #333

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x) #333

merged 3 commits into from
Jul 23, 2024

Conversation

vcheah
Copy link
Contributor

@vcheah vcheah commented Jun 7, 2024 •
edited
Loading

The commit includes:

  1. Fixed BGR4 JPEG Enc (api2x)
  2. Enable YUV400 JPEG Enc (api1x and api2x)

@vcheah vcheah changed the title Enable YUV400 JPEG Enc and BGR4 JPEG Enc (Internal allocator) Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x) Jun 7, 2024
@vcheah
Copy link
Contributor Author

vcheah commented Jun 7, 2024

The CD/CI error does not look like it comes from the MR. Anyone has any idea about this?

@Sherry-Lin
Copy link
Contributor

Yes, there is build regression in recent changes. We are trying to fix it by end of this week.

@vcheah vcheah force-pushed the yuv400_bgr4_enc branch 3 times, most recently from d781e6a to 3fbd1bf Compare June 14, 2024 04:08
@bai-isaac bai-isaac requested a review from leyu-yao June 19, 2024 07:55
@vcheah vcheah force-pushed the yuv400_bgr4_enc branch 3 times, most recently from 6f3665c to f0b0440 Compare July 3, 2024 12:57
@vcheah
Copy link
Contributor Author

vcheah commented Jul 5, 2024

Hi @bai-isaac @OttoYang @leyu-yao,
Could you please help to review?

@OttoYang OttoYang added the verifying PR: fix ready and verifying with build/test label Jul 5, 2024
OttoYang
OttoYang approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@OttoYang OttoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OttoYang
Copy link
Contributor

OttoYang commented Jul 9, 2024

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

@vcheah
Copy link
Contributor Author

vcheah commented Jul 9, 2024

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

Will take a look.

@vcheah
Copy link
Contributor Author

vcheah commented Jul 9, 2024

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

Hi @OttoYang
I have fixed and rebased https://github.com/intel-innersource/drivers.gpu.media.sdk.lib/pull/8723. I got the pr_verify fixed by updating the commits accordingly with OSPR/Issue/Test/GithubPR information (below). I notice now only "Check OS Mergeable" and "Update resources" still the failure. Do you have any idea about this?

OSPR: [PUBLIC]333

Issue: XXXX
Test: -
Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

@OttoYang OttoYang removed the verifying PR: fix ready and verifying with build/test label Jul 10, 2024
@OttoYang
Copy link
Contributor

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

Hi @OttoYang I have fixed and rebased intel-innersource/drivers.gpu.media.sdk.lib#8723. I got the pr_verify fixed by updating the commits accordingly with OSPR/Issue/Test/GithubPR information (below). I notice now only "Check OS Mergeable" and "Update resources" still the failure. Do you have any idea about this?

OSPR: [PUBLIC]333

Issue: XXXX Test: - Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Please fix the issue in this PR, the back merge PR only for verifying.

@vcheah
Copy link
Contributor Author

vcheah commented Jul 10, 2024

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

Hi @OttoYang I have fixed and rebased intel-innersource/drivers.gpu.media.sdk.lib#8723. I got the pr_verify fixed by updating the commits accordingly with OSPR/Issue/Test/GithubPR information (below). I notice now only "Check OS Mergeable" and "Update resources" still the failure. Do you have any idea about this?
OSPR: [PUBLIC]333
Issue: XXXX Test: - Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Please fix the issue in this PR, the back merge PR only for verifying.

@vcheah Please help with the pre-check in failure issue resolved in this PR that was detected in the back merge PR.

Hi @OttoYang I have fixed and rebased intel-innersource/drivers.gpu.media.sdk.lib#8723. I got the pr_verify fixed by updating the commits accordingly with OSPR/Issue/Test/GithubPR information (below). I notice now only "Check OS Mergeable" and "Update resources" still the failure. Do you have any idea about this?
OSPR: [PUBLIC]333
Issue: XXXX Test: - Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Please fix the issue in this PR, the back merge PR only for verifying.

Hi @OttoYang
I have updated the commit message accordingly.

@vcheah
[Encode] Add rgb32 flag for BGR4 case
926b60f 
This is to fix BGR4 JPEG Enc internal alloction case where the
vaattrib never got set. Hence, results in corruption.

OSPR: [PUBLIC]333

Issue: HSD-15015751297
Test: manual
Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Signed-off-by: Cheah, Vincent Beng Keat [email protected]>
@vcheah
[JPEGe] Enable YUV400 JPEG Enc support
6cb1ff3 
The changes only enable YUV400 JPEG Enc support for Linux only.

OSPR: [PUBLIC]333

Issue: VSMGWL-73224
Test: manual
Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Signed-off-by: Cheah, Vincent Beng Keat [email protected]>
@vcheah
[JPEGe] Enable YUV400 internal vaapi allocator
fe55e6e 
OSPR: [PUBLIC]333

Issue: VSMGWL-73224
Test: manual
Github PR: 333 (Enable YUV400 JPEG Enc and BGR4 JPEG Enc (api2x))

Signed-off-by: Cheah, Vincent Beng Keat [email protected]>
@OttoYang OttoYang requested a review from bai-isaac July 11, 2024 01:45
@OttoYang OttoYang added the verifying PR: fix ready and verifying with build/test label Jul 16, 2024
@vcheah
Copy link
Contributor Author

vcheah commented Jul 22, 2024 •
edited
Loading

Hi @OttoYang ,
Could you please help to trigger the innersource build?
Also, please do let me know if there are anything I need to do in order to get this merge.

@gfxVPLsdm gfxVPLsdm merged commit 1323a69 into intel:main Jul 23, 2024
6 checks passed
@vcheah vcheah deleted the yuv400_bgr4_enc branch July 24, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OttoYang OttoYang OttoYang approved these changes

@bai-isaac bai-isaac bai-isaac approved these changes

@leyu-yao leyu-yao Awaiting requested review from leyu-yao

Assignees
No one assigned
Labels
verifying PR: fix ready and verifying with build/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vcheah @Sherry-Lin @OttoYang @bai-isaac @gfxVPLsdm