Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check test coverage #445

Closed
wants to merge 7 commits into from
Closed

Check test coverage #445

wants to merge 7 commits into from

Conversation

yagyanshbhatia
Copy link
Contributor

@yagyanshbhatia yagyanshbhatia commented Jan 23, 2019 •
edited
Loading

resolves #442

Steps @hyzhak you'll need to setup

  1. install istanbul and codecov (or use npm install)
  2. Set in your environment variables
    export CODECOV_TOKEN="<token>" (get the token from the settings tab of https://codecov.io/gh/internetarchive/internet-archive-voice-apps )
  3. in the functions directory, run npm run test and then npm run report-coverage

@yagyanshbhatia
Copy link
Contributor Author

hey @hyzhak I'm not sure updating the package-lock.json was a good decision but travis build wasn't passing without it.

hyzhak
hyzhak suggested changes Jan 24, 2019
View reviewed changes
Copy link
Member

@hyzhak hyzhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you setup Travis CI as well?

README.md Outdated Show resolved Hide resolved
functions/package.json Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9ff3a48). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #445   +/-   ##
=========================================
  Coverage          ?   94.53%           
=========================================
  Files             ?      336           
  Lines             ?     5984           
  Branches          ?        0           
=========================================
  Hits              ?     5657           
  Misses            ?      327           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ff3a48...7a3f594. Read the comment docs.

@yagyanshbhatia
Copy link
Contributor Author

hey @hyzhak I've set up the changes requested (travis ci + nyc). I think we can merge this now. Please take a look at this

hyzhak
hyzhak suggested changes Jan 29, 2019
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@hyzhak
Copy link
Member

hyzhak commented Jan 29, 2019

@yagyanshbhatia excellent! Thank you! There is only small issue and we can merge it

@yagyanshbhatia
Copy link
Contributor Author

@hyzhak okay done. Lets merge this.

@yagyanshbhatia
Copy link
Contributor Author

@hyzhak Is there anything else left to do here? If yes, please let me know

@vbanos vbanos closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyzhak hyzhak hyzhak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check test coverage
4 participants
@yagyanshbhatia @codecov-io @hyzhak @vbanos