Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OCLC / OCN id option on add book page. #8719

Open
hornc opened this issue Jan 15, 2024 · 7 comments · May be fixed by #10006
Open

Include OCLC / OCN id option on add book page. #8719

hornc opened this issue Jan 15, 2024 · 7 comments · May be fixed by #10006
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Books Page Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@hornc
Copy link
Collaborator

hornc commented Jan 15, 2024

https://openlibrary.org/books/add

should provide an option to add an OCLC/WorldCat number (OCN) as an identifier.

It is one of the ids available on the edit page. It seems sensible to also include it on the add page.

Describe the problem that you'd like solved

Proposal & Constraints

Additional context

Stakeholders

@hornc hornc added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 15, 2024
@Ayush1404
Copy link
Contributor

Hey I would like to work on this issue,I believe I can do it

@cdrini
Copy link
Collaborator

cdrini commented Jan 16, 2024

@hornc Should we just include the full identifiers list at this point? It might be nice to DRY the rendering and validation code. CC @seabelis

@Ayush1404 there's still a bit of discussion to be had around this one so not yet ready to work on :)

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Module: Books Page Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jan 16, 2024
@Ayush1404
Copy link
Contributor

Sure , I would love to work on it once the discussion is done , thanks for the reply :)

@seabelis
Copy link
Collaborator

"Should we just include the full identifiers list at this point? "

I'd rather not. Only one can be added at a time on that form; I'd prefer to keep it limited to the most important ones and not social or retail sites.

@hornc
Copy link
Collaborator Author

hornc commented Jan 23, 2024

Yes, I agree with @seabelis , no need to confuse the options, many of which are hardly used. ISBN, LCCN, and OCLC are the three main identifiers we tend to use, and OCLC number is more used than LCCN in some of our systems.

Anecdotally, OCLC numbers get used quite a bit on Wikipedia when people enter references, so it is a book identifier that online bibliophiles are familiar with.

@Freso
Copy link
Contributor

Freso commented Nov 3, 2024

Only one can be added at a time on that form

As I understood @cdrini’s comment, he wanted to include the same identifier “widget” on the add page that’s currently on the edit page (i.e., reuse that code to reduce overall code complexity). This would by extension also mean being able to add multiple identifiers when adding a book. I, personally, think this would be great.


If we don’t want to switch to allowing to add multiple identifiers when adding books, then I agree that not all identifiers should be added to this list—but I also then think the current list of options is too sparse.

isbn_1[03] should obviously be there.
I get wanting “trusted book providers” (e.g., librivox, gutenberg) too. We’re still missing a few from this list (wikisource, openstax, standard_ebooks, + one more soon… 👀), so I’m guessing these ought to be added too?
If OCLC, then ISNI and VIAF might also make sense, being international library system/collaboration identifiers too.
LCCN, on the other hand… I guess? But then we should also, IMHO, add all other national library identifiers, to counter US centricity.

Practical questions:

I’d like to be assigned this if either

  1. the issue remains limited to just OCLC, or
  2. I can add remaining trusted identifiers and inter/national library identifiers (ISNI, VIAF, and whichever library edition identifiers we currently support (that I can recognise/identify)).

I do not want to be assigned this if you want to balloon or repurpose the issue into one for having a better UI on the add page for adding identifiers. (IMHO, if you want to do this, you should make a new issue for that, and allow a simple PR against openlibrary/templates/books/add.html adding OCLC for this issue. Don’t let perfect be the enemy of good and all that.)

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 4, 2024
@hornc
Copy link
Collaborator Author

hornc commented Nov 7, 2024

@Freso I think this issue should be limited to OCLC, so your number 1 above, and I think we can assign this to you.

Good spotting re. the $popular array, it's interesting to see it there, I'm not sure exactly where that is used, and the justification. I'd argue that Librivox and Project Gutenberg ids should be imported more systematically by a process other than user submitted edits, but those are already on the books/add.html page anyway. I think there might be a "show of solidarity" and boosting similar open projects happening there? They should be left alone for now, but I don't think $popular is necessarily the same list as this page.

The use case as I saw it is users adding pre-ISBN books to OL via the wiki interface who wanted to include a unique, disambiguating identifier. Without getting into too much detail, OCLC numbers do seem to be the only available bibliographic id type that can potentially be formally assigned to any book ever published, regardless of where copies are held.

Between ISBN and OCLC number, every book should be able to have an identifier. This issue isn't just about saying "more identifiers are better", in fact there are good reasons not clutter the interface. It's about getting identifier coverage on non-ISBN books that has at least the potential to be complete, and is usable in practical bibliographic exchanges.

I've given examples above how anecdotally it appears to be frequently used this way on Wikipedia for non-ISBN books, and specifically for archive.org integration with Open Library and other library partners, archive.org uses OCLC numbers.

Freso added a commit to Freso/openlibrary that referenced this issue Nov 7, 2024
OCLC ids will usually be available for titles that do not have
an ISBN to identify them and are also used a lot in Wikipedia
to reference publications.

This uses the same ordering used in the `$popular` array for
adding identifiers on the book editing page.

Fixes internetarchive#8719
@Freso Freso linked a pull request Nov 7, 2024 that will close this issue
Freso added a commit to Freso/openlibrary that referenced this issue Nov 19, 2024
OCLC ids will usually be available for titles that do not have
an ISBN to identify them and are also used a lot in Wikipedia
to reference publications.

This uses the same ordering used in the `$popular` array for
adding identifiers on the book editing page.

Fixes internetarchive#8719
@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Books Page Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants