Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted book provider "audiobook" link in carousel on mobile has text overlap with external icon #8899

Open
RayBB opened this issue Mar 12, 2024 · 9 comments · May be fixed by #10112
Open

Trusted book provider "audiobook" link in carousel on mobile has text overlap with external icon #8899

RayBB opened this issue Mar 12, 2024 · 9 comments · May be fixed by #10112
Assignees
@LouisSim
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Mar 12, 2024 •
edited
Loading

Problem

Hard to explain but see screenshot of "audiobook" button

Evidence / Screenshot

Screen Shot 2024-03-12 at 17 44 14

Relevant URL(s)

https://openlibrary.org/works/OL37473900W/Short_Story_Collection_102

Reproducing the bug

  • Expected behavior: No overlap
  • Actual behavior: Overlap

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Android
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

If you want to work on this please confirm that you will read the feedback and progress in the closed PR #9066 and incorporate it into the PR you open.

Related files

Stakeholders

@cdrini
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 12, 2024
@PremBharwani

This comment was marked as outdated.

Sign in to view
@RayBB

This comment was marked as outdated.

Sign in to view
@PremBharwani PremBharwani mentioned this issue Mar 16, 2024
Closed
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 18, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Apr 4, 2024

This issue is open for someone to work on again. You may take inspiration from #8913 which started but still needs work.

@Realmbird
Copy link
Contributor

If I can I work on this issue. Please assign me

@Realmbird Realmbird mentioned this issue Apr 10, 2024
Closed
@camicacace

This comment was marked as outdated.

Sign in to view
@RayBB

This comment was marked as outdated.

Sign in to view
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label May 22, 2024
@RayBB RayBB added Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] and removed Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. labels Nov 27, 2024
@LouisSim
Copy link

LouisSim commented Dec 3, 2024

I can work on this issue. Could you please assign me?

@RayBB
Copy link
Collaborator Author

RayBB commented Dec 3, 2024

@LouisSim yes and please review all of the approaches and feedback in to come up with a solution that works #9066
I don't think the answer to this one is immediately obvious.
When you open a PR please provide screenshots showing how it works on mobile and desktop.

@RayBB RayBB removed the Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] label Dec 3, 2024
@LouisSim LouisSim linked a pull request Dec 4, 2024 that will close this issue
Open
@LouisSim
Copy link

LouisSim commented Dec 4, 2024

@RayBB #10112 PR has been submitted for this issue, let me know if there is anything I need to change or fix

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 4, 2024
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LouisSim LouisSim

Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
6 participants
@RayBB @mekarpeles @Realmbird @PremBharwani @LouisSim @camicacace