Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize cover height and width to prevent page layout shifting #9739

Open
RayBB opened this issue Aug 13, 2024 · 4 comments · May be fixed by #10145
Open

Utilize cover height and width to prevent page layout shifting #9739

RayBB opened this issue Aug 13, 2024 · 4 comments · May be fixed by #10145
Assignees
@anna-ayn
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Aug 13, 2024 •
edited
Loading

Problem

Followup now that #9156 is done

A clear and concise description of what you want to happen

We should start setting the height and width on covers across the website to stop layout shifting.

Additional Context

https://covers.openlibrary.org/b/id/12547191.json

Proposal & Constraints

What is the proposed solution / implementation?

Is there a precedent of this approach succeeding elsewhere?

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

List of places it probably should be set:

Leads

Related files

Stakeholders

@cdrini can update the ticket with additional info.

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Aug 13, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Aug 19, 2024
@anna-ayn
Copy link

Hi @RayBB,

I'm Ana, part of a group of five students from Simón Bolívar University eager to contribute to Open Library. We are particularly interested in this issue and would like to request your permission to work on it. We look forward to your guidance and support. Thank you!

@RayBB
Copy link
Collaborator Author

RayBB commented Nov 24, 2024

@anna-ayn I'll assign this issue to you and your team so you can investigate.
The first step is to determine a list of pages where we show covers so we can prioritize which to update to start using this.
Please read the contributing.md, especially the technical walkthrough.

PS: @cdrini is actually lead on this issue so he'll provide most guidance.

Good luck!

@RayBB
Copy link
Collaborator Author

RayBB commented Dec 10, 2024

@anna-ayn are you and your team still interested in working on this?

@RayBB RayBB removed the Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] label Dec 10, 2024
@anna-ayn
Copy link

Hi @RayBB,

Yes, we are still working on the issue. We believe it will be ready by Friday. Apologies for the delay; we've been quite busy with university commitments.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 11, 2024
@anna-ayn anna-ayn linked a pull request Dec 13, 2024 that will close this issue
Open
@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anna-ayn anna-ayn

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using book cover sizes to prevent layout shifting anna-ayn/stars-openlibrary
4 participants
@RayBB @mekarpeles @cdrini @anna-ayn