Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify whitespace on search results pages (when no search results). #10067

Open
1 task
Tracked by #9232
RayBB opened this issue Nov 22, 2024 · 15 comments · May be fixed by #10152
Open
1 task
Tracked by #9232

Unify whitespace on search results pages (when no search results). #10067

RayBB opened this issue Nov 22, 2024 · 15 comments · May be fixed by #10152
Assignees
@purohitamann
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 22, 2024

Problem

Follow up to #10056
Part of #9232

As you can see below, there is a different amount of whitespace below each search result page.
We should unify them to all match the heights on the "all" and "lists" pages.

ezgif com-optipng

Reproducing the bug

See photos above

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Mac
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • All pages have the same whitespace

Related files

  • See openlibrary/templates/search/

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Bug Something isn't working. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels Nov 22, 2024
@RayBB RayBB mentioned this issue Nov 22, 2024
Open
10 tasks
@Sahil-Gupta584

This comment was marked as outdated.

Sign in to view
@shikharchaurasia

This comment was marked as outdated.

Sign in to view
@RayBB

This comment was marked as outdated.

Sign in to view
@Sahil-Gupta584

This comment was marked as outdated.

Sign in to view
@shikharchaurasia

This comment was marked as outdated.

Sign in to view
@Sahil-Gupta584 Sahil-Gupta584 removed their assignment Nov 23, 2024
@Sahil-Gupta584

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 23, 2024
@RayBB

This comment was marked as outdated.

Sign in to view
@Kvothe045

This comment was marked as outdated.

Sign in to view
@RayBB

This comment was marked as outdated.

Sign in to view
@RayBB RayBB added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Response Issues which require feedback from lead labels Nov 26, 2024
@RayBB RayBB added Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] and removed Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Dec 10, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Dec 10, 2024

There is has been no activity on this issue for 2 weeks. I am unassigning so someone else can ask to work on it.

@purohitamann
Copy link

@RayBB I can start working on this one!

@RayBB
Copy link
Collaborator Author

RayBB commented Dec 10, 2024

@purohitamann you're assigned. Good luck!

@avadhutmali
Copy link

is this issue solved..?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 16, 2024
@purohitamann
Copy link

working on it

@purohitamann purohitamann linked a pull request Dec 17, 2024 that will close this issue
Open
@purohitamann
Copy link

@RayBB please take a look!

@RayBB RayBB removed Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Needs: Response Issues which require feedback from lead labels Dec 17, 2024
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 18, 2024
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purohitamann purohitamann

Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10067/fix/search result purohitamann/openlibrary
6 participants
@RayBB @avadhutmali @shikharchaurasia @purohitamann @Kvothe045 @Sahil-Gupta584