Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facets are not user sensitive (for print disabled books) #9575

Open
RayBB opened this issue Jul 16, 2024 · 3 comments · May be fixed by #10160
Open

Facets are not user sensitive (for print disabled books) #9575

RayBB opened this issue Jul 16, 2024 · 3 comments · May be fixed by #10160
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Jul 16, 2024

Problem

Why does this say “4 ebooks”
But then there are only 2 results (and each has 2 works but only 1 ebook for each)
This is because I don't see the books that are for folks with print disabled permissions but the facet doesn't reflect that.
https://openlibrary.org/search?subject=Apache+Solr

Evidence / Screenshot

image
image

Relevant URL(s)

Slack thread: https://internetarchive.slack.com/archives/C0ETZV72L/p1721157389711519?thread_ts=1721115930.014879&cid=C0ETZV72L

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

n/a

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

@cdrini

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 16, 2024
@cdrini cdrini changed the title Facets are not user sensitve (for print disabled books) Facets are not user sensitive (for print disabled books) Jul 22, 2024
@cdrini cdrini added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: Search Issues related to search UI and backend. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jul 22, 2024
@sbwhitt
Copy link
Collaborator

sbwhitt commented Dec 16, 2024

After recreating the example locally, I found this addition to fix the incorrect ebook counts when the user does not have any printdisabled cookie. This was admittedly my first dive into solr, so I wouldn't be surprised if there was a better approach. If this looks good, I'd be happy to put up a PR!

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 16, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Dec 17, 2024

@sbwhitt I'm not the lead here but I think that looks like a decent fix. I'd recommend opening a PR so @cdrini can easily test it when he's back and determine next steps :)

@sbwhitt sbwhitt linked a pull request Dec 17, 2024 that will close this issue
Open
@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label Dec 19, 2024
@mekarpeles
Copy link
Member

Thank you @sbwhitt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix search facet from mirepresenting the amount of ebook results sbwhitt/openlibrary
4 participants
@RayBB @mekarpeles @cdrini @sbwhitt