Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return cover selector navigation to right and left placement #10134

Open
seabelis opened this issue Dec 9, 2024 · 6 comments · May be fixed by #10169
Open

Return cover selector navigation to right and left placement #10134

seabelis opened this issue Dec 9, 2024 · 6 comments · May be fixed by #10169
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Affects: UI Issues with the web site's user interface. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

seabelis commented Dec 9, 2024

Problem

The cover selector was modified recently to place the nav arrows at the top and bottom of the covers. The covers scroll from right to left, however, and this is counterintuitive. Please restore previous placement.

Screenshot 2024-12-09 at 11 09 29

Reproducing the bug

  1. Go to ...https://openlibrary.org/works/OL...W/title/add-cover
  2. Do ...note awkward placement of nav arrows
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@seabelis seabelis added Type: Bug Something isn't working. [managed] Affects: UI Issues with the web site's user interface. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Lead labels Dec 9, 2024
@Craig-Rosario
Copy link

Hi, i'd love to work on this issue, however the link you provided gives a "404-Page Not Found" error.
Also regarding the issue, would you like the nav arrows to be side by side for better usability?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 10, 2024
@seabelis
Copy link
Collaborator Author

Yes, side by side was a better layout.

@Craig-Rosario
Copy link

Sure, can you assign me the issue so that I can start working on it.

Also then link you send doesn't seem to work, so can you send me the correct link to reproduce the bug.
The current link gives me this:
image

@seabelis
Copy link
Collaborator Author

OL...W represents any Work ID.

@garv-crafteak
Copy link

Hey @seabelis, @mekarpeles

Is this issue still open? I was able to reproduce it successfully during testing and have attached an image for reference. I’d love to work on fixing it and ensure that the navigation buttons are properly set up at the side of the images. Could you please confirm and assign this to me if it’s still unresolved?

Looking forward to your response!

image

@mekarpeles
Copy link
Member

Hi @Craig-Rosario here's a link where you can test
https://openlibrary.org/works/OL69166W/Italian_journeys

We'd love your help, thank you :)

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Needs: Response Issues which require feedback from lead labels Dec 16, 2024
@Craig-Rosario Craig-Rosario linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Affects: UI Issues with the web site's user interface. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed arrow alignment Craig-Rosario/openlibrary
4 participants
@mekarpeles @seabelis @Craig-Rosario @garv-crafteak