Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The accessibility of keyboard navigation of the search bar can be improved #7916

Open
bick-jp opened this issue May 31, 2023 · 4 comments · May be fixed by #9845
Open

The accessibility of keyboard navigation of the search bar can be improved #7916

bick-jp opened this issue May 31, 2023 · 4 comments · May be fixed by #9845
Assignees
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Bug Something isn't working. [managed]

Comments

@bick-jp
Copy link
Collaborator

bick-jp commented May 31, 2023

(Not sure if I should report this as a bug. If not, I'll repost this with the more appropriate type of issue.)
The accessibility of keyboard navigation of the search bar can be improved.

  1. Currently, the auto-suggested list in the search bar is navigated with the tab key. But it should be navigated via arrow keys. And when the tab key is pressed, the focus should move to the next navigation bar item instead of going into the auto-suggested list.

  2. Currently, the auto-suggested list keeps appearing on the screen even after the focus moves out from the search bar. It should disappear when the focus is not on the search bar or on the items of the auto-suggested list.

Evidence / Screenshot (if possible)

When I input the search word, "design" in this case, it automatically shows suggestions.
Screen Shot 2023-05-31 at 3 56 58 PM

When I press the tab key, the focus moves to the search icon.
Screen Shot 2023-05-31 at 3 57 23 PM

Pressing the tab key again, the focus moves to the barcode-ish icon.
Screen Shot 2023-05-31 at 3 57 28 PM

Then, the problem is that pressing the tab key again moves the focus to the suggested list.
Screen Shot 2023-05-31 at 3 57 34 PM

After focusing on all the items in the suggested list, the focus finally moves to the next focusable nev bar item, which is the user icon and hamburger menu in this case.
Screen Shot 2023-05-31 at 3 57 41 PM

Also, another problem is that the suggested list keeps appearing, even after the focus is off from the search bar (in this case, the focus is on "Books").
Screen Shot 2023-05-31 at 3 58 00 PM

Relevant url?

https://openlibrary.org/search?q=design&mode=printdisabled&has_fulltext=true&subject_facet=Protected+DAISY

Steps to Reproduce

  1. Go to https://openlibrary.org/search?q=design&mode=printdisabled&has_fulltext=true&subject_facet=Protected+DAISY
  2. Input any words in the search bar, and navigate the page with the tab key.
  • Actual: Explained as above.
  • Expected:
    ** Auto-suggested list should be navigated using arrow keys.
    ** Pressing the tab key should navigate the focus through the nav bar elements instead of the inside of the auto-suggested list.
    ** The list should disappear when the focus moves out from the suggested list.
    ** When the focus is on the list, users should be able to escape fromit by pressing the Esc key, which I think is a suggested accessible behavior.

Details

  • Logged in (Y/N)? Y
  • Browser type/version? Chrome Version 113.0.5672.126 (Official Build) (arm64)
  • Operating system? macOS Monterey Version 12.3.1
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Search bar keyboard navigation in Google Scholar and GitHub might be good examples.

Related files

Stakeholders

@bick-jp bick-jp added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels May 31, 2023
@mekarpeles mekarpeles added Theme: Accessibility Work related to disability accessibility. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels Jun 5, 2023
@karlitto01
Copy link

Hi @cdrini. I would like to work on this issue, if possible. Thanks.

@mekarpeles mekarpeles added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels May 13, 2024
@RayBB
Copy link
Collaborator

RayBB commented May 22, 2024

@karlitto01 are you still interested in working on this one?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 23, 2024
@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label May 26, 2024
@schu96
Copy link
Contributor

schu96 commented Sep 4, 2024

@RayBB Can you assign me to this issue?

@RayBB
Copy link
Collaborator

RayBB commented Sep 4, 2024

@schu96 you're assigned. Good luck!

@schu96 schu96 linked a pull request Sep 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants