Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mergeDeep with deepCopy from @intlify/shared #399

Open
4 tasks done
BobbieGoede opened this issue Sep 26, 2024 · 1 comment
Open
4 tasks done

Replace mergeDeep with deepCopy from @intlify/shared #399

BobbieGoede opened this issue Sep 26, 2024 · 1 comment
Labels
Package: unplugin-vue-i18n Status: Review Needed Request for review comments Type: Maintenance Repository Maintenance

Comments

@BobbieGoede
Copy link
Member

Reporting a bug?

I might be mistaken but the mergeDeep function looks similar to (maybe an older version of) the deepCopy function exported by @intlify/shared. Replacing it should make it easier to maintain across packages and possibly prevent issues that we have already solved (such as intlify/vue-i18n#1947).

Expected behavior

Reproduction

Issue Package

unplugin-vue-i18n

System Info

-

Screenshot

No response

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the README
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Check that this is a concrete bug. For Q&A open a GitHub Discussion.
@BobbieGoede BobbieGoede added the Status: Review Needed Request for review comments label Sep 26, 2024
@BobbieGoede
Copy link
Member Author

This isn't really a bug (not sure if people are experiencing with deep copy in this plugin) but more of a maintenance issue, I haven't tried reproducing previously found deepCopy issues using the code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: unplugin-vue-i18n Status: Review Needed Request for review comments Type: Maintenance Repository Maintenance
Projects
None yet
Development

No branches or pull requests

1 participant