Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unplugin-vue-i18n): don't analyze identifiers in vue files when using pug/jsx/tsx languages #414

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Nov 9, 2024

This PR includes the following changes in the directives plugin:

  • exclude analyze identifiers when vue files using any of the following languages: pug, jsx and tsx (we cannot parse those languages with @typescript-eslint/typescript-estree)
  • adds a new excludeLangs array containing previous languages to allow add more when required
  • small refactor for perfomance

This PR doesn't fix anything about v-t logic in the directives plugin: v-t cannot be used (ignored/error?)

resolves #402

@kazupon
Copy link
Member

kazupon commented Nov 10, 2024

Thanks!

This PR doesn't fix anything about v-t logic in the directives plugin: v-t cannot be used (ignored/error?)

This PR cannot solve the root issue of #402, but as a workaround, this PR is effective.
This PR will allow us to build it so it will no longer be blocked.
So I would like to merge it and release it as a patch.

By the way, solving the root cause of #402 will take some time.
I have a conference talk coming up at the end of this month, so it will be some time before I can resolve that.

@kazupon kazupon merged commit a01d848 into intlify:main Nov 10, 2024
5 checks passed
@userquin userquin deleted the unplugin-i18n-vite/fix-directives-plugin-error-on-tsx branch November 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with tsx template
2 participants