Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict cancelling of schedules of messages already sent #63

Open
lkwirica opened this issue Jun 21, 2021 · 8 comments
Open

Restrict cancelling of schedules of messages already sent #63

lkwirica opened this issue Jun 21, 2021 · 8 comments
Labels
feature New feature request priority:low Low Priority

Comments

@lkwirica
Copy link

image
image

Related to issue #7

@ashaban
Copy link
Member

ashaban commented Jun 21, 2021

@lkwirica can you give more details about this issue?

@lkwirica
Copy link
Author

For integrity purposes, one can only cancel the record of a scheduled message BEFORE the message is sent out. Once the message has been sent, the record should not be deleted....This way, we can tell, all historical message schedules in the system

@ashaban
Copy link
Member

ashaban commented Jun 21, 2021

@lkwirica This report only shows Active Schedules, Cancelling a schedule doesnt delete, it just deactivate. If you need a report of all scheduled messages we can then add a new report that list all scheduled messages (active and inactive), but not this one

@cloehr651 cloehr651 added the feature New feature request label Jun 21, 2021
@cloehr651
Copy link

@lkwirica if you would like a new report please create a new issue that details what you want that report to include

@lkwirica
Copy link
Author

@ashaban 'Active Schedule' in this case means a schedule whose message has been sent out/ not sent?

The schedules displayed are of messages already sent out....Shouldn't it then display schedules Not yet sent out? As in yet to be activated?

@ashaban
Copy link
Member

ashaban commented Jun 23, 2021

Active Schedules is any schedule whose messages can still be sent out, remember that you can schedule a message to be sent out repeatedly i.e evey Monday and Tuesday, inactive schedule is the one that has either been cancelled or a schedule that can no longer be executed i.e you create a schedule to be executed twice in July, this schedule will be inactive in August.
So the report is displaying active schedules to allow you to cancel any schedule you think it should not be executed or no longer needed to run.

@lkwirica
Copy link
Author

image
@ashaban Since the message was only to be sent out once, and the date passed, this should not be displaying on the 'Scheduled Messages' page...

@ashaban
Copy link
Member

ashaban commented Jun 23, 2021

@lkwirica Yes, it should not, for now that feature is not supported, but you can still manually take them out by cancelling them. We will later add auto cancelling of schedules that has passed their time of execution, but this is not a priority for now since you can still manually cancel schedules.

@ashaban ashaban added the priority:low Low Priority label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request priority:low Low Priority
Projects
None yet
Development

No branches or pull requests

3 participants