changeMetadata doesn't work if the replacement metadata is the same type

[mel-mason]

I think the following should be if (!oldName.equals(newName)), as the comment says 'Only metadata objects of the same type (of the same MetadataType object) can be exchanged'

        if (oldName.equals(newName)) {
            // Different metadata types.
            return false;
        }

https://github.com/intranda/ugh/blob/master/ugh/src/ugh/dl/DocStruct.java#L1649

Same bug is present in changeMetadataGroup (https://github.com/intranda/ugh/blob/master/ugh/src/ugh/dl/DocStruct.java#L1384)

I'm trying a workaround using

List<? extends Metadata> oldMetadata = docStruct.getAllMetadataByType(metadataType);
String value = newMetadata.getValue();
oldMetadata.get(0).setValue(value);

but it won't be as robust.

[opaetzel]

This should be fixed with 542a4ef

Can you check if this is fine for you and close the issue if it is?

[mel-mason]

Thanks! I'm afraid I won't be able to test it any time soon - I don't have a test deployment of goobi yet, and we're not ready for another upgrade in the near future. The fix looks correct to me, though