Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage API response is incorrect when only of the queryParam (fw or bw) is passed #19

Open
sambekar15 opened this issue Sep 25, 2020 · 1 comment · May be fixed by #32
Open

Lineage API response is incorrect when only of the queryParam (fw or bw) is passed #19

sambekar15 opened this issue Sep 25, 2020 · 1 comment · May be fixed by #32

Comments

@sambekar15
Copy link
Contributor

sambekar15 commented Sep 25, 2020

Problem:
Hitting http://localhost:9000/v1/lineage/table/LOREM?bw=2 returns TableNotFound

The API returns full lineage if queryParams are not passed.
For Eg -
http://localhost:8080/api/v1/lineage/table/LOREM- returns full backward and forward lineage
http://localhost:8080/api/v1/lineage/table/LOREM?bw=0 returns full forward Lineage
http://localhost:8080/api/v1/lineage/table/LOREM?fw=0 returns full backward Lineage

But searching for any different depth for a single param results in error -
http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 returns Table "LOREM" not found

Instead it should return http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 => Backward Lineage at depth 2 and full forward Lineage

Expectations: Hitting http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 => Backward Lineage at depth 2 and full forward Lineage

@sambekar15 sambekar15 changed the title Change default backward and forward depth for lineage API to 2 Lineage API response is inconsistent when only of the queryParam is passed Oct 1, 2020
@sambekar15 sambekar15 changed the title Lineage API response is inconsistent when only of the queryParam is passed Lineage API response is incorrect when only of the queryParam (fw or bw) is passed Jul 12, 2021
@sambekar15 sambekar15 assigned sambekar15 and unassigned sambekar15 Oct 1, 2021
@shivrraj
Copy link

shivrraj commented Oct 1, 2021

Problem: Hitting http://localhost:9000/v1/lineage/table/LOREM?bw=2 returns TableNotFound

The API returns full lineage if queryParams are not passed. For Eg - http://localhost:8080/api/v1/lineage/table/LOREM- returns full backward and forward lineage http://localhost:8080/api/v1/lineage/table/LOREM?bw=0 returns full forward Lineage http://localhost:8080/api/v1/lineage/table/LOREM?fw=0 returns full backward Lineage

But searching for any different depth for a single param results in error - http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 returns Table "LOREM" not found

Instead it should return http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 => Backward Lineage at depth 2 and full forward Lineage

Expectations: Hitting http://localhost:8080/api/v1/lineage/table/LOREM?bw=2 => Backward Lineage at depth 2 and full forward Lineage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants