Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging in the application #24

Open
sambekar15 opened this issue Oct 1, 2020 · 2 comments
Open

Add logging in the application #24

sambekar15 opened this issue Oct 1, 2020 · 2 comments
Labels

Comments

@sambekar15
Copy link
Contributor

sambekar15 commented Oct 1, 2020

Is your feature request related to a problem? Please describe.
Currently the application does not have logging. The errors are printed on console. Using logging in your application can be useful for monitoring, debugging, error tracking, and business intelligence.

For eg - Hitting the API - http://localhost:8080/api/v1/lineage/table/LOREM?bw=-1&fw=-1 returns empty response
but stacktrace is not logged. This makes it default to debug.

Describe the solution you'd like
Integrate with Play API logging - https://www.playframework.com/documentation/2.8.x/ScalaLogging
Log the error from API call
Desired output structure in log would be :
%d{yy/MM/dd HH:mm:ss}; thread=%thread; level=%p; %marker; class=%c; method=%method; lineNumber=%L; msg=%message%n%xException

@otobrglez
Copy link

Hello @sambekar15!

Can you provide a splash more information about desired logging output structure or anything more then what is already written in this ticket?

Cheers!

  • Oto

@sambekar15
Copy link
Contributor Author

Hello @sambekar15!

Can you provide a splash more information about desired logging output structure or anything more then what is already written in this ticket?

Cheers!

* Oto

Sure. Desired output structure in log would be -
%d{yy/MM/dd HH:mm:ss}; thread=%thread; level=%p; %marker; class=%c; method=%method; lineNumber=%L; msg=%message%n%xException

sambekar15 added a commit that referenced this issue Oct 1, 2020
Add logging in the application #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants