add change liquidity entrypoint #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zielvna
reviewed
Sep 11, 2024
wojciech-cichocki
requested changes
Sep 12, 2024
| } | ||
|
|
||
| #[ink_e2e::test] | ||
| async fn test_change_liquidity_no_position(mut client: ink_e2e::Client<C, E>) -> E2EResult<()> { |
There was a problem hiding this comment.
Is there a test for insufficient tokens to cover the liquidity change in the position?
sdk/src/invariant.ts
Outdated
| async changeLiquidity( | ||
| account: IKeyringPair, | ||
| index: bigint, | ||
| newLiquidity: Liquidity, |
There was a problem hiding this comment.
deltaLiquidity and depositDirection = DEPOSIT | WITHDRAW suit better IMO
zielvna
approved these changes
Sep 13, 2024
wojciech-cichocki
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes