-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve signature issue #40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 97.39% 96.10% -1.29%
==========================================
Files 5 5
Lines 230 231 +1
==========================================
- Hits 224 222 -2
- Misses 6 9 +3
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…s.jl into wct/typevar-sig
I've update LTS, and removed CI on 1.5 (because Invenia no longer uses 1.5) |
Some lines have been uncovered via the switch to the 1.6 LTS, hence the small drop in coverage. Not sure what we want to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge whenever you want
Addresses #39
I'm not sure if it resolves it correctly, so it would be helpful if someone could check that this is the correct behaviour.