Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve signature issue #40

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Resolve signature issue #40

merged 8 commits into from
Jul 27, 2023

Conversation

willtebbutt
Copy link
Member

Addresses #39

I'm not sure if it resolves it correctly, so it would be helpful if someone could check that this is the correct behaviour.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #40 (a87229c) into master (124baaa) will decrease coverage by 1.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   97.39%   96.10%   -1.29%     
==========================================
  Files           5        5              
  Lines         230      231       +1     
==========================================
- Hits          224      222       -2     
- Misses          6        9       +3     
Files Changed Coverage Δ
src/type_utils.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

src/type_utils.jl Outdated Show resolved Hide resolved
test/type_utils.jl Outdated Show resolved Hide resolved
test/type_utils.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/type_utils.jl Outdated Show resolved Hide resolved
@willtebbutt
Copy link
Member Author

I've update LTS, and removed CI on 1.5 (because Invenia no longer uses 1.5)

@willtebbutt
Copy link
Member Author

Some lines have been uncovered via the switch to the 1.6 LTS, hence the small drop in coverage. Not sure what we want to do

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge whenever you want

@willtebbutt willtebbutt merged commit 23d4aa6 into master Jul 27, 2023
12 of 13 checks passed
@willtebbutt willtebbutt deleted the wct/typevar-sig branch July 27, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants