Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor global/shared styles #204

Open
harunurhan opened this issue Mar 3, 2017 · 1 comment
Open

Refactor global/shared styles #204

harunurhan opened this issue Mar 3, 2017 · 1 comment
Labels
refactoring/code-style RFC

Comments

@harunurhan
Copy link
Contributor

json-editor.component.scss is growing too big and too complex, since we put all shared styles there, because the component has encapsulation: ViewEncapsulation.None to apply all style globally.

I think we should move all shared styles to another file or add more comments to the scss file and seperate them.
@harunurhan
Copy link
Contributor Author

Instead of separating via comments, we could also use multiple scss files since a component takes array of style urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring/code-style RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harunurhan