Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FindReplaceAllService #433

Open
harunurhan opened this issue Nov 17, 2017 · 1 comment
Open

Refactor FindReplaceAllService #433

harunurhan opened this issue Nov 17, 2017 · 1 comment
Labels
refactoring/code-style

Comments

@harunurhan
Copy link
Contributor

Service has a single large method with too many parameters and a lot of TODOs
@harunurhan
Copy link
Contributor Author

Maybe creating the diff could be removed and later could be done with diff library: diffJson(old, replaced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring/code-style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harunurhan