Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rxjs imports and operator usage (use pipe) #460

Open
harunurhan opened this issue Jan 25, 2018 · 1 comment
Open

Refactor rxjs imports and operator usage (use pipe) #460

harunurhan opened this issue Jan 25, 2018 · 1 comment

Comments

@harunurhan
Copy link
Contributor

Instead of import 'rxjs/add/operator...'which does prototype patches Observable, Subject etc., do import { ... } from 'rxjs/operators';. Then compose them, via pipe operator.

https://blog.angularindepth.com/rxjs-understanding-lettable-operators-fe74dda186d3

@mattmutt
Copy link

would recommend moving to rxjs 6 and validating the component against current Angular at some point. There will be necessary library updates to make as well, such as ngx-bootstrap. Currently one would have to patch with a temporary shim library like rxjs-compat. Ideally the right import syntax and pipe operators would fix all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants