-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remove dependencies on unnecessary Invenio-* packages #134
Comments
I don't see any issue with that.
Changed with - view_imp='invenio_files_rest.views.file_download_ui',
+ view_imp='invenio_records_files.views.file_download_ui', Do we need to keep In case somebody wants to use a different record_file_factory they can at the same time provide their own file UI endpoint as it means that there is probably not a 1 record -> 1 bucket relation anymore. |
👍 Would make Files-REST more clean. @nharraud I would still keep |
@lnielsen I meant removing it from the ext.py file in invenio-files-rest, not removing the function which is in invenio-records-files. If we move |
* Removes `record_file_factory` extenstion property. (addresses inveniosoftware#134) * Moves `file_download_ui` utility function to Invenio-Records-Files. Signed-off-by: Jiri Kuncar <[email protected]>
* Removes `record_file_factory` extenstion property. (addresses inveniosoftware#134) * Moves `file_download_ui` utility function to Invenio-Records-Files. Signed-off-by: Jiri Kuncar <[email protected]>
* Removes `record_file_factory` extenstion property. (addresses inveniosoftware#134) * Moves `file_download_ui` utility function to Invenio-Records-Files. * NOTE One must fix import paths in `RECORDS_UI_ENDPOINTS`. Signed-off-by: Jiri Kuncar <[email protected]>
|
@lnielsen after our discussion I believe this one can be closed, the removal of |
It would make package release process easier.
record_file_factory
andfile_download_ui
toinvenio_records_files
(cc @lnielsen @nharraud @tiborsimko)The text was updated successfully, but these errors were encountered: