Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

views: enable views to delete files completely #146

Open
nharraud opened this issue Mar 30, 2017 · 2 comments
Open

views: enable views to delete files completely #146

nharraud opened this issue Mar 30, 2017 · 2 comments

Comments

@nharraud
Copy link
Member

nharraud commented Mar 30, 2017

Problem:
Views don't enable to remove files from disk.
As soon as a file is written it is marked as non writable. Thus remove_file_data is not be able to remove them. This task is used in views.py but will not have any effect.

@lnielsen
Copy link
Member

I don't think I would change remove_file_data. It's there as a protection mechanism, so it shouldn't try to remove a file if it is not writable. I would rather say that the view/API should handle the situation?

@nharraud nharraud changed the title tasks: enable remove_file_data to remove non writable files views: enable views to delete files completely Mar 31, 2017
@nharraud
Copy link
Member Author

nharraud commented Mar 31, 2017

@lnielsen Ok. I changed the issue's title.
What about adding a force optional argument to remove_file_data which would ignore the writable status. The views would then set it to True whenever an ObjectVersion is deleted and there is a need for garbage collection.
Changing the writable flag would allow other file modifications, which is not what we want.

@lnielsen lnielsen added this to the someday milestone Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants