Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing peer dependencies from webpack.py? #158

Open
ZedThree opened this issue Aug 22, 2022 · 0 comments
Open

Missing peer dependencies from webpack.py? #158

ZedThree opened this issue Aug 22, 2022 · 0 comments

Comments

@ZedThree
Copy link

Package version (if known): 2.1.6

Does webpack.py need to include peer dependencies of the packages it uses? react-invenio-forms relies on the following packages, as listed in its peer dependencies:

                "@ckeditor/ckeditor5-build-classic": "^16.0.0",
                "@ckeditor/ckeditor5-react": "^2.1.0",
                "formik": "^2.1.0",

invenio-app-rdm lists them in its webpack.py: https://github.com/inveniosoftware/invenio-app-rdm/blob/87148c6531eac48b28a3cee515c75e759e9dd25b/invenio_app_rdm/theme/webpack.py#L34-L36

Should they in fact be listed in here instead? Otherwise consumers of invenio-search-ui need to list them in their webpacks, but this doesn't appear to documented anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant