Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add webpack build tests #81

Open
lnielsen opened this issue May 15, 2020 · 0 comments
Open

tests: add webpack build tests #81

lnielsen opened this issue May 15, 2020 · 0 comments

Comments

@lnielsen
Copy link
Member

The tests should build the webpack bundle. Currently, with a passing travis build we do not know if the webpack builds or doesn't build. Furthermore the build is dependent on the Webpack config defined by Invenio-Assets (Invenio-Assets is already in requirements-devel.txt thus devel tests will pickup latest webpack config to check if there's any issues).

Proposal:

  • Add a test fixture to pytest-invenio that easily allows testing of themed bundles (basically the fixture/tests should be parameterised to run for each theme defined in APP_THEME).
  • Add documentation to Invenio-Assets on how to test a Webpack bundle.
  • Add test to build the bundle here in Invenio-Search-UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant