Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Translation of funder-names/title not be used #607

Open
chriz-uniba opened this issue Dec 12, 2022 · 0 comments
Open

i18n: Translation of funder-names/title not be used #607

chriz-uniba opened this issue Dec 12, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@chriz-uniba
Copy link
Contributor

Package version (if known): invenio-app-rdm 9.1.5

Describe the bug

There seems no way to get a translation of funder-names.

Steps to Reproduce

  1. Create an invenio-instance with German language enabled.
  2. Create funders-list from ROR-Data as described here: https://inveniordm.docs.cern.ch/customize/vocabularies/names/#creating-a-namesyaml-file --- but for funders

here a subset:

- country: DE
  id: 018mejw64
  identifiers:
  - identifier: 0000 0001 2096 9829
    scheme: isni
  - identifier: 10.13039/501100001659
    scheme: doi
  - identifier: grid.424150.6
    scheme: grid
  name: Deutsche Forschungsgemeinschaft
  title:
    en: German Research Foundation
- country: DE
  id: 04pz7b180
  identifiers:
  - identifier: 0000 0004 0639 2885
    scheme: isni
  - identifier: 10.13039/501100002347
    scheme: doi
  - identifier: grid.5586.e
    scheme: grid
  name: Federal Ministry of Education and Research
  title:
    de: "Bundesministerium f\xFCr Bildung und Forschung"
    en: Federal Ministry of Education and Research
- country: DE
  id: 03bsmfz84
  identifiers:
  - identifier: 0000 0000 9271 7869
    scheme: isni
  - identifier: 10.13039/501100001663
    scheme: doi
  - identifier: grid.452969.5
    scheme: grid
  name: Volkswagen Foundation
  title:
    de: VolkswagenStiftung
    en: Volkswagen Foundation
  1. Add this vocabulary as funder to your instance (see https://inveniordm.docs.cern.ch/customize/vocabularies/funding/#ror-dataset-import)
  2. Switch between English and German language.
  3. Check out the Funder-Names

image

Expected behavior

If there is a German translation of the title, we would have expected it to be used.

if (funderItem.name) {
funderName = funderItem.name;

Maybe this line here could use title with i18n if available and fall back to name if not available.

Additional context

Maybe related to: inveniosoftware/invenio-app-rdm#1868

@chriz-uniba chriz-uniba added the bug Something isn't working label Dec 12, 2022
@chriz-uniba chriz-uniba changed the title Translation of funder-names/title not be used i18n: Translation of funder-names/title not be used Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant