Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PUI] Remove custom themes #5754

Closed
SchrodingersGat opened this issue Oct 19, 2023 · 8 comments · May be fixed by #8384
Closed

[PUI] Remove custom themes #5754

SchrodingersGat opened this issue Oct 19, 2023 · 8 comments · May be fixed by #8384
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Milestone
1.0.0

Comments

@SchrodingersGat
Copy link
Member

Current support for "custom themes" will be removed when we make the switch to the new react UI
@SchrodingersGat SchrodingersGat added Platform UI Related to the React based User Interface refactor user interface User interface labels Oct 19, 2023
@matmair
Copy link
Member

matmair commented Oct 19, 2023

@SchrodingersGat what is the action item here? Remove the backend function?

@SchrodingersGat
Copy link
Member Author

Yes, basically all the current theming support, once we remove the existing UI code

@wolflu05
Copy link
Contributor

But we could still sync the theme for one user, I mean there is still a dark and light mode?

@SchrodingersGat
Copy link
Member Author

@wolflu05 yes that is still there, this is just a reminder to cull the old code once we switch

@github-actions GitHub Actions
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Dec 19, 2023
@matmair
Copy link
Member

matmair commented Dec 20, 2023

Will be needed after PUI is GA

@github-actions github-actions bot removed the inactive Indicates lack of activity label Dec 20, 2023
@matmair matmair added this to the 1.0.0 milestone Feb 1, 2024
@matmair
Copy link
Member

matmair commented Nov 12, 2024

This is addressed in #8384

@matmair matmair changed the title [React] Remove custom themes [PUI] Remove custom themes Nov 12, 2024
@matmair matmair mentioned this issue Nov 12, 2024
Draft
@SchrodingersGat
Copy link
Member Author

Duplicate of #8384

@SchrodingersGat SchrodingersGat marked this as a duplicate of #8384 Nov 12, 2024
@SchrodingersGat SchrodingersGat closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

After 0.17.0: Remove CUI matmair/InvenTree
3 participants
@SchrodingersGat @matmair @wolflu05