Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] report crashing adapters #2447

Open
mcm1957 opened this issue Sep 21, 2023 · 2 comments
Open

[Feature] report crashing adapters #2447

mcm1957 opened this issue Sep 21, 2023 · 2 comments

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Sep 21, 2023

I would suggest to evaluate / discuss the following extension to js-controller which should help to provide improved expirence for users:

Whenever an adapter crashes several times triggering the restart blocker this adapter should be reported to i.e. the statistics server. No details, especially sensitive userdata should be transmitted. It would in my oppinion sufficient if we get some feedback about adapter causing frequent crashes. We (i :-) ) could check the issues oif this adapter and eventually check wether theres some principal problem.

Maybe we should limit this to adapters installed using lates / stable repo to avoid getting alarms from debugging sessions. (The info from where an adapetr is installed should be available as far as I know).

@Apollon77
Copy link
Collaborator

Hm ... not suure because there can be too many reasons for this. Invalid config, network connection broken because of outage or router restars or or or.
I would not know what to do with this information.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Sep 21, 2023

Well invalid config should not CRASH in way triggering restart loop lock normally I would expect.

I would expect to get a list Adapters xyz, abc, ... crashing. With this information one could check those adapters for i.e. unprocessed issues in adapter repo. I would think about this as some outomatic way to report adapters whcih would need a manual check. You may think about this like a integrated creation of an "Check this adapter Issue". So if one could filter the top crashing adapters, one could check them and contact dev, fix them, remove them from repo ... depending on check result.

Currently we do not have any central health statistics for adapters. Sentry is good but ist addressed to the maintainer and ist completly optional.

As a goal I would expect to reduce the number of low quality adapters in repository thus increasing users experience

But of course its OK to discuss this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants