Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: block installation of deprecated adapter npm packages #2840

Open
1 task done
mcm1957 opened this issue Jul 13, 2024 · 1 comment
Open
1 task done

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Jul 13, 2024

No existing issues.

  • There is no existing issue for my request.

Description

Please evaluate if it would be possible (and desired) to prohibit that js-controller (via UI and via cli) installs any adapter release from npm which is marked as deprecated at npm.

Why?

We just had the situation that a broken release could not be unpublished. It is possible to deprectate it.

To prohibit that less experianced users would install this broken release it would be fine if js-controller (and hance cli / admin UI) would no longer install this npm adapter package.

Please note that this ONLY refers to adapter packages. Any dependencies must not be blocked of course

How?

The information that the adapter package is deprecated should be available from npm api and could be checked before startint npm i.

RemarK.
Experienced users which (at least should) know what they are doing can install such a package manually enyway. So I do not see any negative sideeffects. But of course the change should be discussed.

@mcm1957 mcm1957 changed the title [enhancement]: block deprectated adapter released [enhancement]: block installations of deprecated adapter npm packages Jul 13, 2024
@mcm1957 mcm1957 changed the title [enhancement]: block installations of deprecated adapter npm packages [enhancement]: block installation of deprecated adapter npm packages Jul 13, 2024
@Apollon77
Copy link
Collaborator

We have the blocklist and ignoredVerisons, so the developer can add this to the io-package. Why we need to check this extra?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants