Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bsblan adapter to 0.3.1 #2723

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update bsblan adapter to 0.3.1 #2723

merged 2 commits into from
Oct 17, 2023

Conversation

hacki11
Copy link
Contributor

@hacki11 hacki11 commented Oct 5, 2023

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Oct 5, 2023
@github-actions github-actions bot deleted a comment from hacki11 Oct 5, 2023
@hacki11 hacki11 mentioned this pull request Oct 5, 2023
Closed
@github-actions github-actions bot deleted a comment from hacki11 Oct 5, 2023
@mcm1957 mcm1957 removed the must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review label Oct 6, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 6, 2023

@hacki11
Your adapter https://github.com/hacki11/ioBroker.bsblan does not use standard iobroker testing using node 16/18/20

Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository which is also required for stable repository.

Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in forum from apollon77 (Just take from other adapters the samples)

Although your tests signal a green checkmark, they also signal that niode 14 tests have passed. This is impossible and indicates that you test do not include the required integration tests (= test that adapetr starts without error).

I suggest that you completly replace the existing workflow test-and-release by an aup to date version. You may copy the test-and-release.yml workflow from the example adapter or newly created adapter. If you need help, please let us know.

Please feel free if you need any help setting up standard testing and / or if you prefer a that we / I create a PR to fix this.

Please add a comment when you have reviewed and fixed the suggestion or at least commented the suggestions and you think the adapter is ready for a re-review

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 6, 2023
@hacki11 hacki11 changed the title Update bsblan adapter to 0.3.0 Update bsblan adapter to 0.3.1 Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Automated adapter checker

ioBroker.bsblan

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Add comment "RE-CHECK!" to start check anew

@hacki11
Copy link
Contributor Author

hacki11 commented Oct 8, 2023

@mcm1957 I hope I have addressed your topics correctly.

@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 15, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 17, 2023

0.3.1 created 08.10.2023
20 user (9%)
OK

@mcm1957 mcm1957 merged commit 70d3331 into ioBroker:master Oct 17, 2023
12 checks passed
@mcm1957 mcm1957 removed the (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacki11 @mcm1957