Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update countdown to 2.3.0 #4160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jack-blackson
Copy link
Contributor

No description provided.

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels Oct 14, 2024
Copy link

Automated adapter checker

ioBroker.countdown

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

  • 👀 [S522] Please consider migrating to admin 5 UI (jsonConfig).
  • 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
  • 👀 [W953] .npmignore found - consider using package.json object "files" instead.

Adapter releases: https://www.iobroker.dev/adapter/countdown/releases
Adapter statistic: https://www.iobroker.dev/adapter/countdown/statistics

History and usage information for release 2.3.0:

2.3.0 created 20.9.2024 (23 days old)
69 users (7.47%)

2.2.0 (stable) created 25.8.2023 (415 days old)
693 users (stable) (75.00%)

Please verify that this PR really tries to update to release 2.3.0!

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 15, 2024

@jack-blackson
Please either (re)add github based tests for node.js 18 OR adapt engines clause at package.json to require node.js 20 minium.
See https://github.com/jack-blackson/ioBroker.countdown/blob/cd14cb66b636d65cdc7986d1a35940807b374431/package.json#L5

A new release is not yet required but changes must be commited to head branch before release.

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 15, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 17, 2024

jack-blackson/ioBroker.countdown#135

reminder 24.10.2024

@github-actions github-actions bot added the 24.10.2024 remind after 24.10.2024 label Oct 17, 2024
@mcm1957 mcm1957 added the *📬 a new comment has been added label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.10.2024 remind after 24.10.2024 *📬 a new comment has been added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants