-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you for the great package Feature Request React/JS Support #1
Comments
@larebsyed: Thanks! At the moment the project doesn't have support for actions specific to javascript. Some things like:
are expected to work, but things like: goto defintion, find references etc, will not work. If I had a list of plugins that provide these features, I could hook them inside. |
currently I am using https://github.com/ananthakumaran/tide and works with js and ts both. |
@larebsyed: Awesome, I'll try to work on that during the weekend. |
@larebsyed: I spet some time this morning and I came up with the following features: npm project generatorUsing javascript/typescript project detectorWhenever a project is opened that containd tide function delegationFor javascript anf typescript fiels that are part of javascript/typescritp project (see above) functions for:
now point to tide. These functions are meant to be used either directly or via the provided hydra (mostly the later). |
@iocanel Amazing work. I look into it and let you know |
@iocanel Thanks again for the great work. I am facing an issue where opening a javascript file doesn't start the javascript setting for idee. |
@larebsyed: So, the expected behavior is the following: When you open a javascript project (identified by package.json) in the root, the tide-server is started and the bindings are enabled. Maybe the bindings need to be enabled anyway and not just in the context of the project, so that they work even when just editing raw javascript. Would that solve the issue? |
I think your current logic is fine but it seems that on my project the javascript project is not detected automatically. |
@larebsyed: Made a couple of changes.
Can you have a look an let me know how that works for you? |
@iocanel Thanks ill have look and let you know. |
@larebsyed did you have the chance to play with it? |
Sorry @iocanel I had tight schedule couple of month. Ill get back to you asap |
I want to thank you for this amazing plugin, I just wanted to know do you have support for JS.
The text was updated successfully, but these errors were encountered: