Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you for the great package Feature Request React/JS Support #1

Open
larebsyed opened this issue Apr 4, 2019 · 12 comments
Open

Comments

@larebsyed
Copy link

I want to thank you for this amazing plugin, I just wanted to know do you have support for JS.

@iocanel
Copy link
Owner

iocanel commented Apr 5, 2019

@larebsyed: Thanks!

At the moment the project doesn't have support for actions specific to javascript. Some things like:

  • layout
  • templates
  • headers (?)

are expected to work, but things like: goto defintion, find references etc, will not work.

If I had a list of plugins that provide these features, I could hook them inside.

@larebsyed
Copy link
Author

currently I am using https://github.com/ananthakumaran/tide and works with js and ts both.

@iocanel
Copy link
Owner

iocanel commented Apr 5, 2019

@larebsyed: Awesome, I'll try to work on that during the weekend.

@iocanel
Copy link
Owner

iocanel commented Apr 8, 2019

@larebsyed: I spet some time this morning and I came up with the following features:

npm project generator

Using idee-new-project or via the project hydra you can create a new project. This is a simple wrapper around npm that integrates nicely with projectile.

javascript/typescript project detector

Whenever a project is opened that containd package.json or jsconfig.json or tsconfig.json the tide server is automatically restarted using the project root as reference.

tide function delegation

For javascript anf typescript fiels that are part of javascript/typescritp project (see above) functions for:

  • jumping to declaration
  • jumping to references
  • jumping to implementations

now point to tide.

These functions are meant to be used either directly or via the provided hydra (mostly the later).

@larebsyed
Copy link
Author

@iocanel Amazing work. I look into it and let you know

@larebsyed
Copy link
Author

@iocanel Thanks again for the great work. I am facing an issue where opening a javascript file doesn't start the javascript setting for idee.

@iocanel
Copy link
Owner

iocanel commented Apr 9, 2019

@larebsyed: So, the expected behavior is the following:

When you open a javascript project (identified by package.json) in the root, the tide-server is started and the bindings are enabled.

Maybe the bindings need to be enabled anyway and not just in the context of the project, so that they work even when just editing raw javascript. Would that solve the issue?

@larebsyed
Copy link
Author

I think your current logic is fine but it seems that on my project the javascript project is not detected automatically.

@iocanel
Copy link
Owner

iocanel commented Apr 16, 2019

@larebsyed: Made a couple of changes.

  1. the function delegation mentioned above should now work of all js/ts files (regardles of the project that contains them.
  2. fix javascript project detection (also added some unit tests to avoid regression).

Can you have a look an let me know how that works for you?

@larebsyed
Copy link
Author

@iocanel Thanks ill have look and let you know.

@iocanel
Copy link
Owner

iocanel commented May 17, 2019

@larebsyed did you have the chance to play with it?

@larebsyed
Copy link
Author

Sorry @iocanel I had tight schedule couple of month. Ill get back to you asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants