Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LocalContexts Examples #11

Open
pbuttigieg opened this issue Apr 3, 2024 · 9 comments · May be fixed by #23
Open

Create LocalContexts Examples #11

pbuttigieg opened this issue Apr 3, 2024 · 9 comments · May be fixed by #23
Assignees

Comments

@pbuttigieg
Copy link
Collaborator

Building on iodepo/odis-arch#398

Including

  • Projects
  • Datasets
  • Places

@arojas1

@jmckenna
Copy link
Collaborator

jmckenna commented Apr 3, 2024

@pbuttigieg I don't see the pull request here yet

@jmckenna jmckenna changed the title Create LocalContext Examples Create LocalContexts Examples Apr 3, 2024
@pbuttigieg
Copy link
Collaborator Author

No, it's just a branch for now. Don't think we're ready to initiate a PR. we can when we have the other types drafted .

@jmckenna
Copy link
Collaborator

jmckenna commented Apr 3, 2024

Commit was 62185a1 (in the commit message if you enter "... (issue #11)" it would have tagged it here magically).

@pbuttigieg
Copy link
Collaborator Author

Commit was 62185a1 (in the commit message if you enter "... (issue #11)" it would have tagged it here magically).

this issue is linked to the branch where all commits will occur. We don't need to, and shouldn't, cross-reference issues / PRs in each commit message to avoid clutter. exceptions only when there's a need to point to a specific comment in the issue thread .

@jmckenna
Copy link
Collaborator

jmckenna commented Apr 4, 2024

@pbuttigieg tagging commits to issues (or through a pull request) help discover those commits easily later on (I can understand for yourself, as you made the commit, but months from now that commit would be impossible to find, as no one else would know what branch it lives in).

@jmckenna
Copy link
Collaborator

jmckenna commented Apr 4, 2024

(explained by PL offline, I apologize for my questions here). I understand now.

@pbuttigieg
Copy link
Collaborator Author

never apologise for questions :)

For others - the way that GitHub now allows one to auto-link an issue to a branch (named after the issue) negates the need to tag commits, as the whole branch is linked.

We assume this was implemented to cut down clutter

@jmckenna
Copy link
Collaborator

Here is the latest changes (minor formatting changes): local-contexts-project-example.json

@pbuttigieg
Copy link
Collaborator Author

Thanks @jmckenna - getting closer. We have to figure out what properties map to each label and notice, as they are often different kinds of things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants