Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Removing ionic-platform-web-client should replace commented cordova.js #107

Open
Xelom opened this issue Jun 8, 2016 · 0 comments
Open

Comments

@Xelom
Copy link

Xelom commented Jun 8, 2016

When you add ionic-platform-web-client via ionic add ionic-platform-web-client, it comments cordova.js and inserts <!-- Cordova is bootstrapped by ionic-platform-web-client, uncomment this if you remove ionic-platform-web-client... -->

While this is an acceptable warning, after removing ionic-platform-web-client via ionic remove ionic-platform-web-client it does not uncomment cordova.js thus you have to find what is going on if you didn't read the warning in your index.html file.

There is code for replacing commented cordova.js while removing ionic.service-deploy here:
io-config.js#Line:329

We can extend this block to replace commented cordova.js while removing ionic-platform-web-client.

@Xelom Xelom changed the title Removing ionic-platform-web-client should remove commented cordova.js Removing ionic-platform-web-client should replace commented cordova.js Jun 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant