Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all secret manager methods from the wallet? #1765

Closed
Thoralf-M opened this issue Dec 11, 2023 · 2 comments
Closed

Remove all secret manager methods from the wallet? #1765

Thoralf-M opened this issue Dec 11, 2023 · 2 comments
Assignees
@Alex6323
Labels
m-wallet Module - Wallet
Milestone
v2.0.0 (Q1 2024)

Comments

@Thoralf-M
Copy link
Member

Description

Like store_mnemonic(), get_ledger_nano_status(), change_stronghold_password()...

Motivation

Can be called from the secret manager instead and not fail if another secret manager is used

Are you planning to do it yourself in a pull request?

No.
@Thoralf-M Thoralf-M added the m-wallet Module - Wallet label Dec 11, 2023
@Thoralf-M Thoralf-M added this to the v2.0.0 milestone Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Dec 11, 2023
@Alex6323
Copy link
Contributor

Alex6323 commented Feb 5, 2024

I would remove those methods you mentioned because those will clearly only work with one specific secret manager. But we should keep those - if any - that can work with multiple.

@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Mar 4, 2024
@Alex6323 Alex6323 moved this from Sprint Backlog to In Progress in iota-sdk Mar 14, 2024
@Alex6323 Alex6323 mentioned this issue Mar 15, 2024
Closed
@Alex6323 Alex6323 linked a pull request Mar 15, 2024 that will close this issue
Remove more secret manager methods from wallet #2189
Closed
@Alex6323
Copy link
Contributor

Decided to keep those methods for now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-sdk Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex6323 Alex6323

Labels
m-wallet Module - Wallet
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q1 2024)
Development

Successfully merging a pull request may close this issue.

Remove more secret manager methods from wallet Alex6323/iota-sdk
3 participants
@thibault-martinez @Alex6323 @Thoralf-M