Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout for "Manage starnames/iovnames/names" views #1023

Closed

Conversation

albertandrejev
Copy link
Contributor

Closes #1021.

@albertandrejev albertandrejev self-assigned this Feb 17, 2020
package.json Outdated
"eslint-plugin-prettier": "^3.0.1",
"@typescript-eslint/eslint-plugin": "^2.19.2",
"@typescript-eslint/parser": "^2.19.2",
"eslint": "6.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those explicit dependencies have been removed in the past because create react app pulls them in. With this change, you add them twice. What exactly was the idea/problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to remove eslint from global requirements (globally installed package) to local. When I did this and tried to run yarn lint I got lot's of errors about missed packages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint is installed locally, see:

$ cd ponferrada
$ git checkout master
$ yarn install
$ ls -lA node_modules/.bin/eslint
lrwxr-xr-x  1 me  staff  50 17 Feb 16:03 node_modules/.bin/eslint -> ../addons-linter/node_modules/eslint/bin/eslint.js
$ ./node_modules/.bin/eslint --version
v5.16.0
$ yarn eslint --version
yarn run v1.22.0
$ /projects/ponferrada/node_modules/.bin/eslint --version
v5.16.0
✨  Done in 0.76s.

The only question for me is why this is not yet eslint 6 ....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. weird. Let me check again. I am always have troubles with eslint for some reason :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But uninstalling the global version is probably a good idea to avoid confusion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, eslint 5 is installed via mozilla/web-ext and mozilla/addons-linter, which still uses eslint 5. But so far this did not make problems.

@albertandrejev albertandrejev force-pushed the feature/#1021-manage-names branch 2 times, most recently from 61d80e3 to b519c98 Compare February 20, 2020 11:55
@albertandrejev albertandrejev changed the base branch from master to feature/account-module March 4, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage starnames/iovnames/names
2 participants