Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward distribution: instead of the weight, we want to use the amount #967

Open
annatorok opened this issue Jan 17, 2020 · 3 comments
Open

Comments

@annatorok
Copy link

In the governance app, instead of the weight, we want to use the amount as a base for reward distribution.

We want to add a fix amount (with decimal) for reward distribution instead of relying on the weight (in the CSV file).

@abefernan abefernan self-assigned this Jan 24, 2020
@abefernan
Copy link
Contributor

This 100% would need changes in iov-core (iov-bns-governance). In addition, the current implementation distributes all the funds between the recipients according to the weights; in order to distribute fixed amounts we would need to know the funds in advance.

@webmaster128
Copy link
Contributor

The current implementation (which is indeed an IOV Core responsibility) ensures that the entire amount of the rewardFundAddress is split and sent. Having explicit amount comes with the risk of all kind of rounding issues.

What's the motivation for this ticket?

@davepuchyr
Copy link
Contributor

We will need to reward hundreds to thousands of depositors and, due to the limit on the number of txs in a batch, have to split the reward distributions into chunks. That means that we cannot empty the reward fund entirely in the first chunk.

@abefernan abefernan removed their assignment May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants